This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Hotfix - #37 - catch also php 7 throwables #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with tiny variable names and confusing assignments
…ions should also be caught
Closed
|
Would this not fail on PHP 5.6 because the class |
|
@nesl247 PHP < 7 doesn't appear to complain when Throwable is inside of a catch block. See example: http://sandbox.onlinephpfunctions.com/code/66997de5290d58dca15462e867224c9da62e3e14 |
|
Very interesting. I really hope this gets merged in soon then. |
|
@nesl247 type-hints are not causing any autoloading, so it would just be ignored ;-) |
| @@ -199,4 +209,47 @@ public function testShouldAllowDispatchingPsr7Instances() | |||
| $result = $dispatch($route, $err, $request->reveal(), $response->reveal(), $next); | |||
| $this->assertSame($response->reveal(), $result); | |||
| } | |||
|
|
|||
| /** | |||
| * @requires PHP 7.0 | |||
There was a problem hiding this comment.
That's nifty; didn't know about that annotation!
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
…wables Hotfix - #37 - catch also php 7 throwables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides tests for #37